This repository was archived by the owner on Jul 22, 2025. It is now read-only.
DEV: Update modifyClass calls #985
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davidtaylorhq
force-pushed
the
modify-class
branch
from
10fcbcc to
001bd49
Compare
- Update `controller:topic` modification to native class syntax - Remove search-result-entry modification in favour of plugin-outlet-based solution
davidtaylorhq
force-pushed
the
modify-class
branch
from
001bd49 to
593e8dc
Compare
keegangeorge
reviewed
Dec 2, 2024
Comment on lines
+5
to
+7
| function addResultClass(element) { | ||
| element.closest(".fps-result")?.classList.add("ai-result"); | ||
| } |
Member
There was a problem hiding this comment.
Just a heads up: this needs to be conditionally shown only on posts that have generatedByAi not on all search results:
Member
Author
There was a problem hiding this comment.
Thanks @keegangeorge!
I'd assumed that the 'sparkles' icon was only rendered on those results... but now that I look more closely it seems like we're rendering it on every result and then hiding with CSS? 😬
Anyway, I'm not too happy with this .closest() technique. Will close out this PR and make a new one when we have a better strategy.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
controller:topicmodification to native class syntax